Eligibility API logic #286

richherrera · 2024-07-15T22:35:44Z

Reason for changes

DTMOBILES-777

Add the necessary logic to make the request to the Eligibility API GraphQL. With the eligibility checks, the merchant will be able to see if the Venmo flow is eligible or not.

Summary of changes

Add Eligibility Response model
Add Client and API logic
Add docstrings
Add UTs
Add demo functionality

Checklist

Added a changelog entry

Authors

@richherrera

richherrera · 2024-07-15T22:48:43Z

Sources/CorePayments/Eligibility/SupportedPaymentMethods.swift

@@ -0,0 +1,7 @@
+import Foundation
+
+enum SupportedPaymentMethodsType: String {


I added this enum based on the logic that was previously removed:

paypal-ios/Sources/CorePayments/Networking/GraphQL/SupportedPaymentMethodsType.swift

Line 1 in 257df31

enum SupportedPaymentMethodsType: String {

sshropshire

🔥

Sources/CorePayments/Eligibility/EligibilityResponse.swift

jaxdesmarais · 2024-07-16T16:24:26Z

Sources/CorePayments/Eligibility/EligibilityResponse.swift

+    let paypal: SupportedPaymentMethodsTypeEligibility
+    let paylater: SupportedPaymentMethodsTypeEligibility


Suggested change

let paypal: SupportedPaymentMethodsTypeEligibility

let paylater: SupportedPaymentMethodsTypeEligibility

let payPal: SupportedPaymentMethodsTypeEligibility

let payLater: SupportedPaymentMethodsTypeEligibility

Updated: cd016e3

scannillo · 2024-07-16T20:41:32Z

Demo/Demo/ViewModels/VenmoPaymentsViewModel.swift

+        }
+        do {
+            let config = try await configManager.getCoreConfig()
+            let eligibilityRequest = EligibilityRequest(currencyCode: "USD", intent: .CAPTURE)


Take it or leave it - maybe we want to leave a TODO for this, but this intent will have to be the same intent used to create the orderID which will eventually get used when constructing a VenmoCheckoutRequest(orderID: "<ORDER_ID>")

i've updated it by adding the intent as a parameter and making changes to the UI: 8f253cf](8f253cf)

scannillo · 2024-07-16T20:43:49Z

Sources/CorePayments/Eligibility/EligibilityAPI.swift

+
+extension EligibilityAPI {
+
+    static let rawQuery = """


I don't think we really need this to be in an extension here. Was there a particular reason for using it?

I decided to put the query in an extension to make the code more readable. I based it on this implementation where the query is in the same method, which makes the method much larger. Basically, it's to separate(ish) responsibilities

We could also throw it in a private method under check if we want to separate it but move it out of the extension

scannillo · 2024-07-16T20:44:06Z

Sources/CorePayments/Eligibility/EligibilityClient.swift

@@ -1,9 +1,36 @@
 import Foundation

+/// The `EligibilityClient` class provides methods to check eligibility status based on provided requests.


👏 Nice docstrings

scannillo · 2024-07-16T20:47:56Z

Sources/CorePayments/Eligibility/EligibilityIntent.swift

@@ -0,0 +1,10 @@
+import Foundation
+
+public enum EligibilityIntent: String {


Actually, I wonder if we only support CAPTURE and AUTHORIZE. Per these PP docs, these are the only 2 you can create an orderID with.

I think it would be OK to just start with those 2. Also needs a docstring since public

🤔 docs says SALE and AUTHORIZE, thanks for your feedback

Updated, I also changed cases to lowercase to be more Swifty: 54e53c0

agedd

very clean docstrings - lgtm!! 🚀

jaxdesmarais · 2024-07-18T13:13:54Z

Demo/Demo/ViewModels/VenmoPaymentsViewModel.swift

+
+    let configManager = CoreConfigManager(domain: "Venmo Payments")
+
+    @Published var state = VenmoState()


Take it our leave it for this PR, but we started a transition to use a new CurrentState enum across all of the views vs individualized views with custom states. If you take a look at the PayPal Web Payments views you can see where that was in motion. Not a blocker, would just be nice to eventually share duplicated states with a shared interface. Can totally be a follow up or something we tackle when we address the other view since only PayPal Web was updated thus far.

Updated, thanks for your feedback: 33d3d46

jaxdesmarais · 2024-07-18T13:14:34Z

PayPal.xcodeproj/project.pbxproj

@@ -570,31 +581,27 @@
 			path = Models;
 			sourceTree = "<group>";
 		};
-		62D3FB122C3DB4B30046563B /* VenmoPaymentsTests */ = {
+		459633142C46BD51002008EF /* Recovered References */ = {


I'm guessing we can remove these Recovered References?

Nice catch, updated: f9f2df3

PayPal.xcodeproj/project.pbxproj

jaxdesmarais · 2024-07-18T13:16:57Z

Sources/CorePayments/Eligibility/EligibilityAPI.swift

+
+extension EligibilityAPI {
+
+    static let rawQuery = """


We could also throw it in a private method under check if we want to separate it but move it out of the extension

jaxdesmarais · 2024-07-18T13:19:03Z

Sources/CorePayments/Eligibility/EligibilityResponse.swift

+    }
+
+    var asResult: EligibilityResult {
+        .init(


Suggested change

.init(

EligibilityResult(

Done: 644df70

jaxdesmarais · 2024-07-18T13:20:17Z

Sources/CorePayments/Eligibility/SupportedPaymentMethods.swift

@@ -0,0 +1,7 @@
+import Foundation
+
+enum SupportedPaymentMethodsType: String {


Do we want to lowercase these as well or keep as is since it's internal?

Great idea!!! Done: b422115

Sources/CorePayments/Eligibility/EligibilityAPI.swift

Co-authored-by: Jax DesMarais-Leder <[email protected]>

richherrera added 30 commits July 11, 2024 09:41

Add EligibilityRequest file

2a07770

Add EligibilityResult file

f50baa8

Add EligibilityClient file

e564f3e

Add EligilibilityClient method

193ab5c

Add Result properties

de28ce6

Add request properties

fc37fd6

Add EligibilityVariables file

de7bf1a

Remove header

e0573a1

Add EligibilityAPI

c0000b4

Sort directory

8a9f7e0

Add properties and initializers

fa4863c

Add tests files

e366890

Fix lints

bfd4749

Fix lint

a3000a1

PR Feedback

f63935d

Conform Encodable and add variable eligibility variables properties

fdc17bf

Add supported currency type enum

26b72e4

Add eligibility intent enum

7fb6765

Add eligibility result properties

8daa52b

Add Eligibility Response object

4198535

Sort files Eligibility directory

c1b1a75

Update eligibility request with enum types

3d41794

Add parameters and initializer on Client

7ff6bb1

Add API logic

1a34e59

Add mock and remove intent enum

4a87950

Remove final

d8b3b76

Add docstrings on Client

805304d

Expose intents

8dbf00c

Change Decodable instead of Codable for response model

32dddf8

Update Variables struct

65749c2

richherrera commented Jul 15, 2024

View reviewed changes

richherrera marked this pull request as ready for review July 15, 2024 22:50

Add functionality on demo app

1ee3d2b

Base automatically changed from fix-venmo-feature-merge to venmo-feature July 16, 2024 14:18

Merge branch 'venmo-feature' into eligibility-logic-request

65ebc50

sshropshire approved these changes Jul 16, 2024

View reviewed changes

jaxdesmarais reviewed Jul 16, 2024

View reviewed changes

richherrera added 4 commits July 16, 2024 12:46

PR feedback

cd016e3

Change initializer

c9f14ab

Fix tests

ee7e160

Fix coding key

9a6dc5a

scannillo reviewed Jul 16, 2024

View reviewed changes

agedd approved these changes Jul 17, 2024

View reviewed changes

richherrera added 3 commits July 17, 2024 13:31

Add EligibilityIntent docstrings and remove unnecessary intents

54e53c0

Fix UTs

df51eb0

Pass intent as parameter and mimic UI as others views

8f253cf

jaxdesmarais reviewed Jul 18, 2024

View reviewed changes

richherrera added 5 commits July 18, 2024 12:47

Change initializer

644df70

Remove Recovered References directory

f9f2df3

Lowercase supported payment methods

b422115

Use CurrentState enum instead of VenmoState

33d3d46

Remove VenmoState file

fb550e2

jaxdesmarais approved these changes Jul 18, 2024

View reviewed changes

Sources/CorePayments/Eligibility/EligibilityAPI.swift Show resolved Hide resolved

Update Sources/CorePayments/Eligibility/EligibilityAPI.swift

19239f9

Co-authored-by: Jax DesMarais-Leder <[email protected]>

richherrera merged commit c281aa9 into venmo-feature Jul 18, 2024
5 checks passed

richherrera deleted the eligibility-logic-request branch July 18, 2024 22:04

sshropshire mentioned this pull request Jul 23, 2024

CorePayments: EligibilityClient paypal/paypal-android#268

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eligibility API logic #286

Eligibility API logic #286

richherrera commented Jul 15, 2024 •

edited

Loading

richherrera Jul 15, 2024

sshropshire left a comment

jaxdesmarais Jul 16, 2024

richherrera Jul 16, 2024

scannillo Jul 16, 2024

richherrera Jul 17, 2024

scannillo Jul 16, 2024

richherrera Jul 17, 2024

jaxdesmarais Jul 18, 2024

scannillo Jul 16, 2024

scannillo Jul 16, 2024

scannillo Jul 16, 2024

richherrera Jul 17, 2024

richherrera Jul 17, 2024

agedd left a comment

jaxdesmarais Jul 18, 2024

richherrera Jul 18, 2024

jaxdesmarais Jul 18, 2024

richherrera Jul 18, 2024

jaxdesmarais Jul 18, 2024

jaxdesmarais Jul 18, 2024

richherrera Jul 18, 2024

jaxdesmarais Jul 18, 2024

richherrera Jul 18, 2024

		@@ -0,0 +1,7 @@
		import Foundation

		enum SupportedPaymentMethodsType: String {

		let paypal: SupportedPaymentMethodsTypeEligibility
		let paylater: SupportedPaymentMethodsTypeEligibility

		@@ -1,9 +1,36 @@
		import Foundation

		/// The `EligibilityClient` class provides methods to check eligibility status based on provided requests.

		@@ -0,0 +1,10 @@
		import Foundation

		public enum EligibilityIntent: String {


		let configManager = CoreConfigManager(domain: "Venmo Payments")

		@Published var state = VenmoState()

Eligibility API logic #286

Eligibility API logic #286

Conversation

richherrera commented Jul 15, 2024 • edited Loading

Reason for changes

Summary of changes

Checklist

Authors

Choose a reason for hiding this comment

sshropshire left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agedd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richherrera commented Jul 15, 2024 •

edited

Loading